Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] fix unclickable links on mobile #3314

Merged
merged 1 commit into from
Sep 28, 2024
Merged

[v3] fix unclickable links on mobile #3314

merged 1 commit into from
Sep 28, 2024

Conversation

dimaMachina
Copy link
Collaborator

fixes #3313

Copy link

changeset-bot bot commented Sep 28, 2024

🦋 Changeset detected

Latest commit: b15b908

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-docs Patch
nextra Patch
nextra-theme-blog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 2:15pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 2:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Sep 28, 2024 2:15pm

Copy link
Contributor

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 167.64 KB (🟡 +15 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link
Contributor

📦 Next.js Bundle Analysis for docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 174.93 KB (🟢 25 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/docs/blog-theme/start 14.08 KB (-1 B) 189.01 KB
/docs/docs-theme/built-ins 11.29 KB (-1 B) 186.22 KB
/docs/docs-theme/start 14.27 KB (1 B) 189.2 KB
/docs/docs-theme/theme-configuration 16.27 KB (🟢 7 B) 191.2 KB
/docs/guide 11.45 KB (-1 B) 186.38 KB
/docs/guide/advanced/mermaid 7.6 KB (🟢 1 B) 182.53 KB
/docs/guide/advanced/remote 6.99 KB (🟢 -1 B) 181.92 KB
/docs/guide/built-ins 11.35 KB (-1 B) 186.29 KB
/docs/guide/built-ins/tabs 10.87 KB (-1 B) 185.8 KB
/docs/guide/custom-css 7.12 KB (🟢 1 B) 182.05 KB
/docs/guide/search 7.95 KB (🟢 -3 B) 182.88 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@dimaMachina dimaMachina merged commit d9d0820 into main Sep 28, 2024
9 checks passed
@dimaMachina dimaMachina deleted the v3-115 branch September 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nextra-theme-docs] links are unclickable on mobile
1 participant