Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes #33

Merged
merged 2 commits into from
May 27, 2024
Merged

various fixes #33

merged 2 commits into from
May 27, 2024

Conversation

m-jahn
Copy link
Collaborator

@m-jahn m-jahn commented May 13, 2024

  • fixes getIdeogram issue

@m-jahn m-jahn requested a review from showteeth May 16, 2024 07:52
@m-jahn m-jahn self-assigned this May 16, 2024
@m-jahn m-jahn added the documentation Improvements or additions to documentation label May 16, 2024
@m-jahn m-jahn marked this pull request as ready for review May 16, 2024 09:13
@m-jahn
Copy link
Collaborator Author

m-jahn commented May 16, 2024

Hi @showteeth!
Can you get back to me regarding your opinion about CRAN submission?
I have made changes that make the package pass all tests so far. I would like to submit it, and if you like, I can take over the maintenance of the package.

However I don't want to submit to CRAN without your explicit confirmation that you are OK with these changes.
You can write me an email (jahn at mpusp.mpg.de or we discuss here on github.

@m-jahn m-jahn merged commit 3aa2d4d into showteeth:main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@showteeth showteeth Awaiting requested review from showteeth

Assignees

@m-jahn m-jahn

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@m-jahn