Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actual) Resolvers for Finance: show available room for income an… #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajakvk
Copy link
Contributor

@rajakvk rajakvk commented Dec 29, 2021

…d expense for each category

Closes #27

Original feature request
shoonyatech/wallora.com#109

* @returns workItems for Income and Expense Categories
*/
async getActualsWorkItems(v1AccessToken,v2AccessToken) {
return this.get(`stats/total-actual-amount-workitemwise?startdate=20211201&enddate=20211231`, null, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes hard coded dates. Please use startDate and endDate params instead

}
/**
* Get actual amount for Income and Expense Categories
* @param v1AccessToken
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove token from docs

@@ -31,4 +31,30 @@ export class WalloraAPI extends RESTDataSource {
headers: this.getHeaders(v1AccessToken, v2AccessToken),
});
}
/**
* Get planned amount for Income and Expense Categories
* @param v1AccessToken
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove tokens from API doc comment

async getPlannedWorkItems(v1AccessToken,v2AccessToken, month) {
console.log('Access Token1:', v1AccessToken);
console.log('Access Token2:', v2AccessToken);
return this.get(`stats/total-planned-amount-workitemwise?startmonth=202112&endmonth=202112`, null, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes hard coded dates. Please use startDate and endDate params instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required resolvers for wallora issue #109
2 participants