Expense tags #17
Open
Expense tags #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souvikbasu
requested changes
Jul 28, 2021
| const tagResolvers = { | ||
| Query: { | ||
| tags: (root, {}, { v1AccessToken, v2AccessToken, dataSources }) => { | ||
| return { expensetags }; |
There was a problem hiding this comment.
remove the curly bracket to fix the error you are getting as the schema expects an array to be returned
| @@ -0,0 +1,84 @@ | |||
| const expensetags = [ | |||
There was a problem hiding this comment.
remove this file from here and add to MSW. GraphQL should only return real data
|
|
||
| const tagResolvers = { | ||
| Query: { | ||
| tags: (root, {}, { v1AccessToken, v2AccessToken, dataSources }) => { |
There was a problem hiding this comment.
make a call to the REST api to get tags
const tagResolvers = {
Query: {
tags: async (root, {}, { v1AccessToken, v2AccessToken, dataSources }) => {
const tags = await dataSources.walloraAPI.getTags(
v1AccessToken,
v2AccessToken
);
return tags;
},
},
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.