-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tool jolicode/castor #746
Conversation
That's so cool. Thanks @shivammathur do you know when you will release it? (No pressure, I'm just asking) |
Thanks for the feedback. we'll look at it Side question: how do you debug window platform? |
Looks like the Do you have a reproducer? Edit: I updated the workflow to run on ubuntu, windows and darwin, and it's all right : https://github.com/pyrech/castor-setup-php/actions/runs/5359907062/jobs/9724101264?pr=2 |
Awesome, good to know. Yes, I think we could improve Castor behavior when no initial castor.php have been created yet. Thanks |
Hello, For your information, the -V flag has been fixed, even if no castor.php file exist And do you know when you'll be able to release a new version? Thanks 💛 |
No worries, that's awesome, thanks for the release 🎉 |
A Pull Request should be associated with a Discussion.
Related discussion: #745
Description
This PR add support for the tool jolicode/castor.
A demo repository is provided here: https://github.com/pyrech/castor-setup-php (see this run for a working demo with my fork)
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.