Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullet stacks #3456

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Bullet stacks #3456

wants to merge 27 commits into from

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Sep 29, 2024

About The Pull Request

!!!! NEEDS BALANCING !!!! NOT ALL AMOUNT OF BULLETS PER BOX IS CORRECT !!!!

Most code from Mojave Sun
Adds bullet handfuls. You can only have the same type of ammunition in a handful. No mismatched stacks
Spent casings are not stackable for now
Also replaces old ammo boxes with storage boxes that come pre-filled with stacks of bullets like this:
image
Here's how the stacks look:
image
image

Changelog

🆑
add: Added bullet stacks, they allow you to stack ammo of the same type into a group.
balance: Changed old ammo boxes into storage items containing stacks of bullets
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Sep 29, 2024
@thgvr thgvr marked this pull request as draft September 29, 2024 08:10
@Sun-Soaked
Copy link
Contributor

it's peam

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Sep 29, 2024
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. and removed Merge Conflict Use Git Hooks, you're welcome. labels Oct 5, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 5, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Map Change Tile placing is hard. Thank you for your service. label Oct 5, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 5, 2024
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Oct 5, 2024
@thgvr thgvr changed the title Bullet handfuls Bullet stacks Oct 5, 2024
thgvr and others added 4 commits October 5, 2024 18:19
Signed-off-by: thgvr <81882910+thgvr@users.noreply.github.com>
Signed-off-by: thgvr <81882910+thgvr@users.noreply.github.com>
Signed-off-by: thgvr <81882910+thgvr@users.noreply.github.com>
@DrCrawler
Copy link
Contributor

Clicking one stack with another should add the clicked stack to the one you clicked it with imo.

@MajorMeltdown
Copy link

  1. Rubbershot box does not: ship out; or spawn with ammo inside
  2. 5.56x42 CLIP ammo box crate says it will send 120 bullets; box it ships sends 4 stacks of 12 bullets. that's deadly little bullets

@thgvr
Copy link
Member Author

thgvr commented Oct 6, 2024

yeah I haven't changed any amounts yet but it is adjustable per box

@Bjarl
Copy link
Contributor

Bjarl commented Oct 6, 2024

image
This is like. Genuinely awful. I think it would be better served as being something you take out of the box instead of the box being filled with them

@thgvr
Copy link
Member Author

thgvr commented Oct 6, 2024

image
that's a bug

@Bjarl
Copy link
Contributor

Bjarl commented Oct 6, 2024

ouhh

@generalthrax
Copy link
Contributor

You can get invisible 0 bullet stacks. Just activate 1 bullet bullet stacks in your hand.

@Sun-Soaked
Copy link
Contributor

image that's a bug

my cranial implant explodes
I should just do a regex find on all these

Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 8, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants