Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with testthat 1.1.0 #5

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

hadley
Copy link
Contributor

@hadley hadley commented Sep 28, 2021

Unfortunately the upcoming testthat 1.1.0 makes some minor changes to how expect_warning() works that broke your tests. We'll hopefully be submitting testthat to CRAN on Friday, so you may want to re-release in the near future to avoid test failures on CRAN.

@hadley hadley mentioned this pull request Sep 28, 2021
43 tasks
@shikokuchuo shikokuchuo self-requested a review September 28, 2021 20:45
Copy link
Owner

@shikokuchuo shikokuchuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadley Thanks.

@shikokuchuo shikokuchuo merged commit 858283b into shikokuchuo:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants