Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Asanpardakht driver (#180) #183

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

Mohammadreza-73
Copy link
Contributor

@Mohammadreza-73 Mohammadreza-73 commented Mar 26, 2023

  • Handle paymeny currency (Rial, Toman)

Description

Add currency in payment config for Asanpardakht driver.

Motivation and context

Why is this change required? What problem does it solve?
I handle currency in Rial and with Asanpardakht driver, multiply 10 to convert amout to Rial!

If it fixes an open issue, please link to the issue here (if you write fixes #180
or closes #180, the issue will be automatically closed when the pull is accepted.)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

* Handle paymeny currency (Rial, Toman)
@Mohammadreza-73
Copy link
Contributor Author

طبق issue #180 ، در درایور آسان پرداخت مبلغی که من خودم به ریال دارم در عدد 10 ضرب می شود.

برای مدیریت این کار میشه طبق این PR برای کانفیگ درایورها مقدار currency هم مشخص نمود.
این مقدار بیانگر واحد مالی هست که توسعه دهنده در برنامه خود از آن استفاده می کند.

@Mohammadreza-73
Copy link
Contributor Author

Mohammadreza-73 commented Mar 26, 2023

اگر با این روش موافق هستید میشه برای کانفیگ هر درایور currency را مشخص نمود.
یا اینکه یک کانفیگ کلی برای این کار داشته باشیم.

return [
    // Default Driver
    'default' => 'zarinpal',
    'currency' => 'T'  // Can be R, T
]

@parsariyahi
Copy link

مرسی که انجام دادی.

@khanzadimahdi khanzadimahdi merged commit 6e63c5b into shetabit:master Apr 9, 2023
@Mohammadreza-73 Mohammadreza-73 deleted the currency-feature branch April 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants