Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Change versioning schema? #4

Closed
e2jk opened this issue Jul 27, 2014 · 10 comments
Closed

Question: Change versioning schema? #4

e2jk opened this issue Jul 27, 2014 · 10 comments
Labels
discussion
Milestone
0.5.0

Comments

@e2jk
Copy link

e2jk commented Jul 27, 2014

The current versioning scheme is:

  • an increasing integer (at the moment 41)
  • prepended by "0.0"
  • appended by "beta" (lower case, with space when displayed, without space in the release zipfiles' filenames)

The latest version is currently "0.0.41 beta".

In an email discussion with @sebsauvage in 2011 (actual version then was 0.0.30beta), when I asked if the version number might get changed in the future Seb's answer was:

Sinon pour le numéro de version, je n'ai aucune stratégie marketting :-)
Je garde le beta pour bien signaler que ça peut casser...

That things might break, I think 3 years further down the line we see it's reasonably stable, and we could drop the "beta" part.

The double 0 in the beginning doesn't have much sense either, to my opinion.

I would suggest we move to something a bit more conventional, either 0.43 (with the idea we would go to v 1.0 some time, and then rediscuss a new versioning scheme from there on), or just keep it simple and call the next version v43.

I would like to have @sebsauvage's input before we change anything, hence my proposition to release 0.0.42beta in #3. Let's wait for him to be back from vacation to weigh-in on this question.
@e2jk e2jk mentioned this issue Jul 27, 2014
Closed
@e2jk e2jk added the question label Jul 27, 2014
@Sbgodin
Copy link

Sbgodin commented Jul 27, 2014

From my little perspective, I think we may keep the current beta version and soon release an official v1.0.0 as Shaarli is fully working worldwide.

@nodiscc
Copy link
Member

nodiscc commented Aug 3, 2014

What I think:

  • 0.0.42 is released
  • we keep fixing bugs and release 0.0.43, 44, 45...
  • we wait for @sebsauvage to change the release to 1.0.0
  • we keep going with 1.0.1, 1.0.2, 1.0.3... for bug fixes, new features
  • once a minor release has been tested and stable for a while (6 months?), we release it as 1.1.0
  • and so on

@Sbgodin
Copy link

Sbgodin commented Aug 3, 2014

Ok for me :-)

@e2jk
Copy link
Author

e2jk commented Aug 4, 2014

Yes, makes sense to me as well. Let's wait for @sebsauvage to give us his thoughts.

@nodiscc
Copy link
Member

nodiscc commented Dec 2, 2014

Still no reply from @sebsauvage. Things are moving here, and we still haven't bumped the version number, despite the numerous bug fixes and improvements. So this is what I plan:

I have created the 0.9beta milestone, which currently references 9 bugs (please click the more link to know what is planned for 0.9beta).

  • Once these bugs are fixed (some work but it's doable), we'll release and tag version 0.9beta.
  • @e2jk you can then use tags/RSS to detect version changes for the Debian watchfile, as discussed in Use Github's tagged versions to detect if new version is available #5, Version check: check against latest version on github #31 (currently Debian packages are frozen anyway, so no hurry)
  • We will keep using shaarli_version.txt for updates detection inside Shaarli; the current update check code is working, and has several benefits (simple text file; users are free to edit their update check URL, no need to host it on github, no need to setup RSS feeds, no need to access Github API).
  • After the release we will contact @sebsauvage again to see if he's interested in a merge.
    • There will be a lot of changes for him to review, so let's do our best to keep the changes clean, simple and well tested.
    • Some complex commits like CSS cleanup/refactoring are necessary if we want to keep fixing bugs, but if they're well documented/split like this this will be ok.
    • This fork is in a good shape and has several active contributors, I hope this will make Seb want to maintain/co-maintain the project again! Contacting him with very few or half-baked changes to propose might not interest him.
  • We may want to reconsider who has write access to the repositories after the release (currently @Alkarex @BoboTiG @e2jk @nodiscc @Sbgodin @sebsauvage @timovn. @ArthurHoaro has write access to the https://github.com/shaarli/templates repo). This can be discussed on IRC or anywhere for that matter.
  • After a decent testing period (3 months?), if everything is stable, if contributions start decreasing, and hopefully the merge back to sebsauvage/Shaarli is done, or @sebsauvage drops his repository and starts maintaining/recommending this one, we will drop the beta flag and release 1.0.

And by the way a huge thanks to everyone contributing. The changes since sebsauvage#191 was opened are great. A quick overview: some forks merged - changes added by this fork - commit activity - a new documentation - issues triaged, reported and fixed - traffic stats

@Alkarex
Copy link

Alkarex commented Dec 2, 2014

Sounds good to me :-)

@nodiscc nodiscc added this to the 0.9beta milestone Jan 9, 2015
@nodiscc
Copy link
Member

nodiscc commented Feb 20, 2015

Should we release v0.0.43beta now? There have been many improvements since the last release, and I think the current code is stable. The v0.9beta milestone still holds.

@e2jk
Copy link
Author

e2jk commented Feb 20, 2015 via email

@nodiscc
Copy link
Member

nodiscc commented Feb 20, 2015

v0.0.43beta released! Thanks to everyone involved.

@nodiscc
Copy link
Member

nodiscc commented Mar 18, 2015

Closing this as the planned versioning is now detailed in milestones

@nodiscc nodiscc closed this as completed Mar 18, 2015
@virtualtam virtualtam modified the milestones: 0.9.0, 0.5.0 Jul 30, 2015
ArthurHoaro referenced this issue in ArthurHoaro/Shaarli Mar 12, 2017
@ArthurHoaro
Proper error if the conf file is invalid instead of fatal error
c6a4c28 
Error:

An error occurred while parsing configuration JSON file (data/config.json.php): error code #4
➜ Syntax error
Please check your JSON syntax (without PHP comment tags) using a JSON lint tool such as jsonlint.com.
@ArthurHoaro ArthurHoaro mentioned this issue Mar 12, 2017
Merged
@bes1967 bes1967 mentioned this issue Dec 2, 2017
Closed
@crishnakh crishnakh mentioned this issue Nov 9, 2020
Closed
@uraza uraza mentioned this issue Nov 23, 2020
Closed
ajabep added a commit to ajabep/Shaarli that referenced this issue Apr 2, 2021
@ajabep
Fix a bug
2ea2c99 
When we try to access the atom feed and have no bookmarks, it raised the following exception :

```
Call to a member function reorder() on array /webroot/application/bookmark/BookmarkFileService.php:143
#0 /webroot/application/feed/FeedBuilder.php(106): Shaarli\Bookmark\BookmarkFileService->search(Array, 'public', false, false, true)
shaarli#1 /webroot/application/front/controller/visitor/FeedController.php(47): Shaarli\Feed\FeedBuilder->buildData('atom', Array)
shaarli#2 /webroot/application/front/controller/visitor/FeedController.php(20): Shaarli\Front\Controller\Visitor\FeedController->processRequest('atom', Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#3 [internal function]: Shaarli\Front\Controller\Visitor\FeedController->atom(Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
shaarli#4 /webroot/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(40): call_user_func(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
shaarli#5 /webroot/vendor/slim/slim/Slim/Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
shaarli#6 /webroot/application/front/ShaarliMiddleware.php(55): Slim\Route->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#7 [internal function]: Shaarli\Front\ShaarliMiddleware->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#8 /webroot/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Array, Array)
shaarli#9 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#10 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#11 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\Route->Slim\{closure}(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#12 /webroot/vendor/slim/slim/Slim/Route.php(268): Slim\Route->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#13 /webroot/vendor/slim/slim/Slim/App.php(503): Slim\Route->run(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#14 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\App->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#15 /webroot/vendor/slim/slim/Slim/App.php(392): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#16 /webroot/vendor/slim/slim/Slim/App.php(297): Slim\App->process(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#17 /webroot/index.php(177): Slim\App->run(true)
shaarli#18 {main}
```
ArthurHoaro referenced this issue in ArthurHoaro/Shaarli May 8, 2021
@ajabep @ArthurHoaro
Fix a bug
c973add 
When we try to access the atom feed and have no bookmarks, it raised the following exception :

```
Call to a member function reorder() on array /webroot/application/bookmark/BookmarkFileService.php:143
#0 /webroot/application/feed/FeedBuilder.php(106): Shaarli\Bookmark\BookmarkFileService->search(Array, 'public', false, false, true)
#1 /webroot/application/front/controller/visitor/FeedController.php(47): Shaarli\Feed\FeedBuilder->buildData('atom', Array)
#2 /webroot/application/front/controller/visitor/FeedController.php(20): Shaarli\Front\Controller\Visitor\FeedController->processRequest('atom', Object(Slim\Http\Request), Object(Slim\Http\Response))
#3 [internal function]: Shaarli\Front\Controller\Visitor\FeedController->atom(Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
#4 /webroot/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php(40): call_user_func(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
#5 /webroot/vendor/slim/slim/Slim/Route.php(281): Slim\Handlers\Strategies\RequestResponse->__invoke(Array, Object(Slim\Http\Request), Object(Slim\Http\Response), Array)
shaarli#6 /webroot/application/front/ShaarliMiddleware.php(55): Slim\Route->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#7 [internal function]: Shaarli\Front\ShaarliMiddleware->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#8 /webroot/vendor/slim/slim/Slim/DeferredCallable.php(57): call_user_func_array(Array, Array)
shaarli#9 [internal function]: Slim\DeferredCallable->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#10 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(70): call_user_func(Object(Slim\DeferredCallable), Object(Slim\Http\Request), Object(Slim\Http\Response), Object(Slim\Route))
shaarli#11 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\Route->Slim\{closure}(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#12 /webroot/vendor/slim/slim/Slim/Route.php(268): Slim\Route->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#13 /webroot/vendor/slim/slim/Slim/App.php(503): Slim\Route->run(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#14 /webroot/vendor/slim/slim/Slim/MiddlewareAwareTrait.php(117): Slim\App->__invoke(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#15 /webroot/vendor/slim/slim/Slim/App.php(392): Slim\App->callMiddlewareStack(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#16 /webroot/vendor/slim/slim/Slim/App.php(297): Slim\App->process(Object(Slim\Http\Request), Object(Slim\Http\Response))
shaarli#17 /webroot/index.php(177): Slim\App->run(true)
shaarli#18 {main}
```
@nejcmenard nejcmenard mentioned this issue Sep 9, 2021
Closed
@jwhaleyca jwhaleyca mentioned this issue Feb 26, 2023
Closed
@aracnus aracnus mentioned this issue Jan 19, 2024
Closed
@nodiscc nodiscc mentioned this issue Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
5 participants
@e2jk @Alkarex @virtualtam @Sbgodin @nodiscc