[BEAM-5123] Testsuite do not run all the tests it should #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaclavPlajt
changed the title
dmvk
pushed a commit
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
that referenced
this pull request
Aug 17, 2018
mareksimunek
suggested changes
Aug 20, 2018
| for (Class<?> testClass : testClasses) { | ||
| LOG.info(String.format("Testkit will schedule tests in '%s'.", testClass)); |
There was a problem hiding this comment.
Meanwhile exception messages doesnt provide good solution for formatting, logging methods do. I would prefer, String.format is uselesss here or is there some benefit?
LOG.info("Testkit will schedule tests in {}.", testClass);
There was a problem hiding this comment.
No benefit. Only the info method has unclear contract to me. I do not know how to log Throwable with custom message without putting Throwable as last formatting parameter. Something which can potentially break once SLF4J implementation changes.
| @@ -59,7 +59,9 @@ public TestSuiteRunner(Class<?> klass) throws Throwable { | |||
| BeamRunnerWrapper runner = | |||
There was a problem hiding this comment.
Its not used now, why is it there?
|
Few minor changes and we are good to go :) |
VaclavPlajt
force-pushed
the
vasek/testsuit-fix
branch
from
ea13274
to
ee0b7d7
Compare
…OperatorTestSuite` fixed by moving it. It forces explicit imports. Some new info level logs added.
…d since it is both not working with `BeamFlow` and unnecessary due to translation to Beam. Small documentation and test changes.
…such as `ClassAwareKryoCoder` removed.
VaclavPlajt
force-pushed
the
vasek/testsuit-fix
branch
from
56a4d6f
to
5f552a4
Compare
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
that referenced
this pull request
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class import collision unearthed and fixed. New logs recording test suite test methods resolving added. Small cleanup (unused parameter, unwanted TODO).
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)