Fix missing optimized shaders on OpenHarmony #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
jschwender/ohos_optimize_shaders
branch
from
0813c62
to
80a7393
Compare
We use GLES on OpenHarmony, so the shaders should be optimizied accordingly. Cargo guarantees that the CARG_CFG variables are set. Using expect instead of matching improves the readability. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
jschwe
force-pushed
the
jschwender/ohos_optimize_shaders
branch
from
80a7393
to
0348b9b
Compare
mrobinson
approved these changes
Aug 28, 2024
20 tasks
|
I've added it to the tracking issue in the main servo repo so I don't forget. |
It isn't done regularly now, but the hope is that in the future it could become more regular. So far I've done it twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use GLES on OpenHarmony, so the shaders should be optimizied accordingly.
Cargo guarantees that the
CARGO_CFG_xxxvariables are set. Using expect instead of matching improves the readability.