-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid large memcpy's #3358
Labels
Comments
Would be good to have this tool hosted somewhere for us to use. |
This was referenced Nov 27, 2018
I put the tool up at https://github.com/jrmuizel/memcpy-find |
bors-servo
pushed a commit
that referenced
this issue
Nov 27, 2018
Introduce SerializedDisplayItem to reduce mem copies on DL construction This PR addresses the part of #3358 about DL construction: instead of constructing the display items and associated data and passing through the serializer by value, we just pass the references around, which guarantees that no extra copies are made. TODO: - [x] verify that the copies are gone (need the tool hosted/opened somewhere) - [x] Gecko try push with talos jobs <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3361) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Nov 28, 2018
Avoid picture primitive copies via VecHelper This is a successor of #3360 that avoids the borrow checker dance via RAII Addresses part of #3358 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3362) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over the weekend I wrote at tool to find large constant memcpys in Rust code.
Here's the output for the webrender crate:
The text was updated successfully, but these errors were encountered: