Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for no_std compilation through an "std" feature #22

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

dflemstr
Copy link
Contributor

@dflemstr dflemstr commented Dec 3, 2019

This ended up being quite straightforward. To make sure that I didn't have to change anything else, alloc is enabled for tests, and documentation is conditionally excluded when the "std" feature is disabled.

@tomaka
Copy link

tomaka commented Jan 22, 2020

Can I gently ping this PR?

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can we add a test pass for no_std?

@dflemstr
Copy link
Contributor Author

Done!

@Manishearth Manishearth merged commit 23c4110 into servo:master Jan 23, 2020
@tomaka
Copy link

tomaka commented Mar 24, 2020

Would it also be possible to publish a new version on crates.io? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants