Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose many additional bindings #9

Merged
merged 11 commits into from
Aug 1, 2018
Merged

Conversation

pcwalton
Copy link

@pcwalton pcwalton commented Jul 6, 2018

Includes bindings to the following:

  • Simulations

  • Informational strings

  • Metrics

  • Outlines

  • Fetching the font corresponding to a face

r? anyone (I'm not sure who maintains this repo)

@pcwalton pcwalton changed the title Expose bindings to the following: Expose many additional bindings Jul 6, 2018
@mbrubeck
Copy link

mbrubeck commented Jul 6, 2018

@bors-servo r+

@bors-servo
Copy link

📌 Commit 1b19b79 has been approved by mbrubeck

@bors-servo
Copy link

⌛ Testing commit 1b19b79 with merge 1d9bc08...

bors-servo pushed a commit that referenced this pull request Jul 6, 2018
Expose many additional bindings

Includes bindings to the following:

* Simulations

* Informational strings

* Metrics

* Outlines

* Fetching the font corresponding to a face

r? anyone (I'm not sure who maintains this repo)
@bors-servo
Copy link

💔 Test failed - status-appveyor

@pcwalton
Copy link
Author

pcwalton commented Jul 6, 2018

I don't understand the AppVeyor failure.

@pcwalton
Copy link
Author

pcwalton commented Jul 6, 2018

@mbrubeck Do you know what to do about this failure?

@mbrubeck
Copy link

mbrubeck commented Jul 6, 2018

No idea, sorry. :(

@pcwalton
Copy link
Author

pcwalton commented Jul 6, 2018

Does anyone object if I push it through anyway?

I'll leave this for a few days so that anyone can object and/or diagnose the failure. If there are no objections I'll go ahead and push it through. cc @nox @jdm

@pcwalton pcwalton force-pushed the additions branch 2 times, most recently from aa3be98 to e9df849 Compare July 26, 2018 21:18
@pcwalton
Copy link
Author

r? @mbrubeck

@jdm
Copy link
Member

jdm commented Jul 26, 2018

With respect to the failure, it looks similar to rust-lang/rust#48272. We've disabled mingw builds in other repositories when they've exhibited build errors that we haven't been able to diagnose successfully, since for Servo builds we only care about MSVC.

@mbrubeck
Copy link

r+ to manually merge, and/or switch the appveyor build from gnu to msvc toolchain

@pcwalton
Copy link
Author

@jdm I'd be happy to change the AppVeyor configuration. Could you provide a link to instructions on how to do this? Thanks!

@bors-servo
Copy link

☔ The latest upstream changes (presumably #11) made this pull request unmergeable. Please resolve the merge conflicts.

@pcwalton
Copy link
Author

pcwalton commented Aug 1, 2018

@bors-servo: r=mbrubeck

@bors-servo
Copy link

📌 Commit e69c5c0 has been approved by mbrubeck

@bors-servo
Copy link

⌛ Testing commit e69c5c0 with merge fc56316...

bors-servo pushed a commit that referenced this pull request Aug 1, 2018
Expose many additional bindings

Includes bindings to the following:

* Simulations

* Informational strings

* Metrics

* Outlines

* Fetching the font corresponding to a face

r? anyone (I'm not sure who maintains this repo)
@bors-servo
Copy link

☀️ Test successful - status-appveyor
Approved by: mbrubeck
Pushing fc56316 to master...

@bors-servo bors-servo merged commit e69c5c0 into servo:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants