Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventTimeout supporting expression #816

Closed
fjtirado opened this issue Feb 7, 2024 · 1 comment · Fixed by #819
Closed

EventTimeout supporting expression #816

fjtirado opened this issue Feb 7, 2024 · 1 comment · Fixed by #819
Assignees

Comments

@fjtirado
Copy link
Collaborator

fjtirado commented Feb 7, 2024

What would you like to be added:
Currently, timeouts are required to be ISO 8601 string. That makes sense but it would be nice to add the possibility of that ISO 8601 string to be the result of evaluating an expression.

Why is this needed:
This will allow defining a recurrent timeout as a conts in the header of the file and then refer to it later on in several places. Hence, if the timeout has to change later, you can change it in just one place.

See example

  "constants": {"duration":"PT5S"}

  "timeouts": {
        "eventTimeout": "$CONST.duration"
      }

@ricardozanini
Copy link
Member

ricardozanini commented Feb 8, 2024

The PR should cover:

  • Update the spec schema (maybe evaluating to add a regexp to validate it's a expression or a ISO string)
  • Update the docs

@ricardozanini ricardozanini changed the title EventTimout supporting expression EventTimeout supporting expression Feb 8, 2024
fjtirado added a commit to fjtirado/specification that referenced this issue Feb 15, 2024
… expressions as

timeout duration

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
fjtirado added a commit to fjtirado/specification that referenced this issue Feb 15, 2024
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@redhat.com>
@ricardozanini ricardozanini linked a pull request Feb 15, 2024 that will close this issue
9 tasks
ricardozanini added a commit that referenced this issue Feb 15, 2024
Fix #816 - Allows using expression for timeout duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants