-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extensions on IServiceCollection #70
Conversation
src/Serilog.Extensions.Hosting/SerilogServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
test/Serilog.Extensions.Hosting.Tests/SerilogServiceCollectionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/Serilog.Extensions.Hosting.Tests/SerilogServiceCollectionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/Serilog.Extensions.Hosting.Tests/SerilogServiceCollectionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
…ons.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ExtensionsTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
LGTM! Thanks @mburumaxwell and @sungam3r for the review 👍 I'll bump the dev package version to 5.1.0-* to indicate new feature additions. |
Can a followup pr be made to split the servicecollection versions over into an Also, then the hosting package could depend on that package as well which should be ok as Microsoft.Extensions.DependencyInjection would be provided anyways. |
Cool. Looking forward to the release. |
This makes sense. Maybe you can do the PR? If we have to move things, instead of a new package, I'd move the extensions to |
Yeah, I think putting it in the logging package would be better as well. And yes, I think the hosting package can be deprecated after this (which would help you guys more with less packages to maintain). |
@AraHaan I believe that's for @nblumhardt to decide, being the maintainer. |
Yeah, I know that. I was just saying what I was thinking as well. |
This adds new extensions on
IServiceCollection
similar to those onIHostBuilder
. Also changed the implementation of the ones inIHostBuilder
to rely on the new extensions for easier maintenance in the future. The implementation logic as pertains to registration of services remains the same.Fixes: #66, #68