Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete APIs and little cleanup #338

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

sungam3r
Copy link
Contributor

No description provided.

@nblumhardt
Copy link
Member

Thanks @sungam3r 👍

I'm on vacation but should be back to full capacity next week.

@SimonCropp
Copy link
Contributor

@nblumhardt LGTM. do we bump a major for this change?

@nblumhardt
Copy link
Member

@SimonCropp this package's versioning tracks ASP.NET Core's, so I think this falls in naturally with the 8.0 release (which we'll need to start assembling soon).

Bumping major to 8.0.0 on dev seems fine, as long as the ASP.NET Core package dependencies also move forward to 8 before we release it 👍

@nblumhardt nblumhardt merged commit 5ca0d90 into serilog:dev Sep 27, 2023
@nblumhardt nblumhardt mentioned this pull request Nov 15, 2023
@sungam3r sungam3r deleted the cleanup branch March 19, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants