Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax SDK version pinning in global.json #175

Closed
ralphhendriks opened this issue Feb 24, 2020 · 0 comments · Fixed by #176
Closed

Relax SDK version pinning in global.json #175

ralphhendriks opened this issue Feb 24, 2020 · 0 comments · Fixed by #176

Comments

@ralphhendriks
Copy link
Contributor

As discussed on Gitter, it seems reasonable to relax the .NET Core SDK version pinning a bit. Right now, this repo is tightly pinned to 3.1.102.

See here for configuration options in global.json.

Pinning to the feature band (e.g. 3.1.1xx) seems to give the right trade off between build consistency and developer friendliness.
ralphhendriks added a commit to ralphhendriks/serilog-aspnetcore that referenced this issue Feb 24, 2020
@ralphhendriks
Pin .NET Core SDK version to latest feature band
b1ae127 
Pin the .NET Core SDK version to the `3.1.1xx` feature band. Do not
allow prerelease versions.

Fixes serilog#175
@ralphhendriks ralphhendriks mentioned this issue Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin .NET Core SDK version to latest feature band ralphhendriks/serilog-aspnetcore
1 participant
@ralphhendriks