Use #[non_exhaustive] where applicable #959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! This changes all of those odd
__Nonexhaustive
enum cases, so that they instead use the#[non_exhaustive]
attribute.However, I opted not to add the#[non_exhaustive]
attribute to any structs where it could apply (that is, those who had a__nonexhaustive: ()
field), since I'm unsure if the effects would be acceptable:That said, if it's desired that I add it to any applicable structs, I can do so.Side note: I did notice #752 while searching to see if there was an existing PR that made this change -- but being that the PR is from December 2019, I imagine there would be lots of merge conflicts and other misc issues that would make it hard to merge that. So I decided to make my own PR.