Implement Display for Permissions
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
requested changes
Aug 23, 2020
arqunis
added
enhancement
arqunis
approved these changes
Aug 23, 2020
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #932.
I wrote the
get_permission_namesmethod by hand first but decided to use a macro later to make it easier to add new permissions.For the
USE_VADpermission, I used "Use Voice Activity" as the name as it's used by Discord on the Developer Portal. Similarly, I used the name used on the portal for theMENTION_EVERYONEpermission. It is called "Mention @everyone, @here, and All Roles" in the app.