Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide old presence data on update #2852

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Provide old presence data on update #2852

merged 1 commit into from
Apr 28, 2024

Conversation

jamesbt365
Copy link
Member

Gaming

@github-actions github-actions bot added client Related to the `client` module. cache Related to the `cache`-feature. examples Related to Serenity's examples. labels Apr 26, 2024
@jamesbt365 jamesbt365 marked this pull request as draft April 26, 2024 14:12
@jamesbt365 jamesbt365 marked this pull request as ready for review April 26, 2024 14:22
@jamesbt365
Copy link
Member Author

Hopefully this isn't considered "too expensive", though if you are running with presence data you probably are expecting the additional overhead.

Also, anything against collapsing getting the guild into a let mut guild = cache.guilds.get_mut(guild_id)?; instead of if let Some(x)?

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Apr 26, 2024
@jamesbt365
Copy link
Member Author

Actually ready for review now, I stopped being stupid.

@arqunis arqunis merged commit 69ca4c0 into serenity-rs:next Apr 28, 2024
21 checks passed
@jamesbt365 jamesbt365 deleted the presence-old-data branch April 28, 2024 23:58
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (serenity…
160da93 
…-rs#2852)
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (#2852)
ca32250
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (#2852)
1afa27f
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (#2852)
9082254
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (serenity…
8edab28 
…-rs#2852)
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (#2852)
e1fd2ce
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (serenity…
04a04d8 
…-rs#2852)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@jamesbt365 @mkrasnitski
Provide old presence data from the cache on presence update (serenity…
395281b 
…-rs#2852)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@jamesbt365 @mkrasnitski
Provide old presence data from the cache on presence update (serenity…
ee1adda 
…-rs#2852)
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@jamesbt365 @GnomedDev
Provide old presence data from the cache on presence update (#2852)
9a1bdbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. client Related to the `client` module. enhancement An improvement to Serenity. examples Related to Serenity's examples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbt365 @arqunis