Add parameter with_localizations to get_global_application_commands
#2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
http
|
This is a breaking change. Ideally the PR should be redesigned to not need a breaking change, but if impossible, it should be retargeted at the |
|
Thank you! |
|
I actually prefer the breaking changes - parameterizing the endpoint using two separate methods seems kinda weird. However, if that's what we're sticking with, you should add wrapper methods to |
arqunis
approved these changes
May 18, 2023
|
By the way @acdenisSK, you can also push commits onto PR branches. Would be a bit cleaner and possibly easier than manually merging |
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 21, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.