Implement From for ByteArray, ByteBuf and Bytes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xZensh <txr1883@gmail.com>
dtolnay
reviewed
Jun 14, 2024
src/bytebuf.rs
Outdated
Comment on lines
134
to
136
| impl<T> From<T> for ByteBuf | ||
| where | ||
| T: Into<Vec<u8>>, |
There was a problem hiding this comment.
This impl looks too general to me. For example, this would block us from adding impl From<ByteBuf> for Vec<u8>.
There was a problem hiding this comment.
Indeed. I made some adjustments.
|
Hey, @dtolnay, any other suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement From for ByteArray, ByteBuf and Bytes.
Implement Default for ByteArray.