Skip to content

Commit

Permalink
tests/robustness: Disable testing network blackhole until etcd-io#15595
Browse files Browse the repository at this point in the history
… is fixed

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
  • Loading branch information
serathius committed Mar 31, 2023
1 parent e11a323 commit 013e25f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 14 deletions.
8 changes: 5 additions & 3 deletions tests/robustness/failpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ var (
CompactBeforeSetFinishedCompactPanic, CompactAfterSetFinishedCompactPanic,
CompactBeforeCommitBatchPanic, CompactAfterCommitBatchPanic,
RaftBeforeLeaderSendPanic,
BlackholePeerNetwork,
DelayPeerNetwork,
// TODO(https://github.com/etcd-io/etcd/issues/15595): Re-enable after issue is fixed
//BlackholePeerNetwork,
}
RandomOneNodeClusterFailpoint Failpoint = randomFailpoint{oneNodeClusterFailpoints}
RaftBeforeFollowerSendPanic Failpoint = goPanicFailpoint{"raftBeforeFollowerSend", nil, Follower}
Expand All @@ -78,8 +79,9 @@ var (
RaftBeforeSaveSnapPanic Failpoint = goPanicFailpoint{"raftBeforeSaveSnap", triggerBlackholeUntilSnapshot, Follower}
RaftAfterSaveSnapPanic Failpoint = goPanicFailpoint{"raftAfterSaveSnap", triggerBlackholeUntilSnapshot, Follower}
RandomSnapshotFailpoint Failpoint = randomFailpoint{[]Failpoint{
RaftBeforeApplySnapPanic, RaftAfterApplySnapPanic, RaftAfterWALReleasePanic, RaftBeforeSaveSnapPanic, RaftAfterSaveSnapPanic,
BlackholeUntilSnapshot,
// TODO(https://github.com/etcd-io/etcd/issues/15595): Re-enable after issue is fixed
//RaftBeforeApplySnapPanic, RaftAfterApplySnapPanic, RaftAfterWALReleasePanic, RaftBeforeSaveSnapPanic, RaftAfterSaveSnapPanic,
//BlackholeUntilSnapshot,
}}
)

Expand Down
23 changes: 12 additions & 11 deletions tests/robustness/linearizability_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,17 +136,18 @@ func TestRobustness(t *testing.T) {
e2e.WithSnapshotCount(100),
),
},
{
name: "Snapshot",
failpoint: RandomSnapshotFailpoint,
traffic: &HighTraffic,
config: *e2e.NewConfig(
e2e.WithGoFailEnabled(true),
e2e.WithSnapshotCount(100),
e2e.WithSnapshotCatchUpEntries(100),
e2e.WithPeerProxy(true),
),
},
// TODO(https://github.com/etcd-io/etcd/issues/15595): Re-enable after issue is fixed
//{
// name: "Snapshot",
// failpoint: RandomSnapshotFailpoint,
// traffic: &HighTraffic,
// config: *e2e.NewConfig(
// e2e.WithGoFailEnabled(true),
// e2e.WithSnapshotCount(100),
// e2e.WithSnapshotCatchUpEntries(100),
// e2e.WithPeerProxy(true),
// ),
//},
}...)
for _, scenario := range scenarios {
if scenario.traffic == nil {
Expand Down

0 comments on commit 013e25f

Please sign in to comment.