Change token form iframe visibility method #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golive
changed the title
golive
force-pushed
the
token-form-iframe-visibility
branch
from
a5c10e6
to
72418e0
Compare
igarciasequra
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal?
CKO risk.js library needed for https://sequra.atlassian.net/browse/MUF-655 doesn't work if rendered inside an iframe that is
display: none, so the iframe need to be hidden in a different way.References
How is it being implemented?
Replace
display: nonewith off-the viewport styles.Opportunistic refactorings
No
Caveats
No
Does it affect (changes or update) any sensitive data?
_Check Sensitive data list documentation and Sensitive data list
How is it tested?
Automatic tests
How is it going to be distributed?
Standard distribution