Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform support added #49

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

munishchouhan
Copy link
Member

@munishchouhan munishchouhan commented Dec 19, 2023

This PR will solve the issue of generating the correct SHA for different artifacts in the homebrew formula
To achieve this, I will remove the brew template and let the jreleaser create it for wave-cli

  1. Remove brew formula template
  2. multiplatform flag set to true in jreleaser brew packager
  3. Reverted to binary artifacts from zip

@munishchouhan munishchouhan marked this pull request as ready for review December 19, 2023 15:44
@munishchouhan
Copy link
Member Author

@pditommaso this PR is ready for review
this will generate this kind of formula
https://github.com/munishchouhan/homebrew-tap/blob/main/Formula/wave-cli.rb

@pditommaso
Copy link
Contributor

@pditommaso
Copy link
Contributor

Paths are going to be github.com/seqeralabs right?

https://github.com/munishchouhan/homebrew-tap/blob/main/Formula/wave-cli.rb#L9

@munishchouhan
Copy link
Member Author

Paths are going to be github.com/seqeralabs right?

https://github.com/munishchouhan/homebrew-tap/blob/main/Formula/wave-cli.rb#L9

These are autogenerated by jreleaser
so it will automatically choose the username, where its running
now we are not providing any config, so paths will be good

@munishchouhan
Copy link
Member Author

This formula generated by this run
https://github.com/munishchouhan/wave-cli/actions/runs/7264210483

@munishchouhan
Copy link
Member Author

we have the same repo here also
https://github.com/seqeralabs/homebrew-tap

@pditommaso
Copy link
Contributor

What about the license

@munishchouhan
Copy link
Member Author

What about the license

Sure, I will change it

@munishchouhan munishchouhan self-assigned this Dec 19, 2023
@munishchouhan
Copy link
Member Author

@pditommaso license changed

@pditommaso
Copy link
Contributor

Nice, thanks

@pditommaso pditommaso merged commit aa61832 into master Dec 19, 2023
11 checks passed
@munishchouhan munishchouhan deleted the homebrew-multiplatform-support branch June 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants