Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: what is "customArgs"? Does it correspond to "unique_args" in the API? #1373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jameshfisher
Copy link

I want to set unique arguments using this library. However, I can't see any way to do that. I can see a field called customArgs, but it's unclear whether this is the same thing. Can you point me to documentation on field?

@jameshfisher
Copy link
Author

I found through testing that setting customArgs: { foo: "bar"} results in the Email Activity dashboard showing an email with "Unique Args: foo: bar".

So it appears to just be badly named. I suggest that the customArgs field in this library is renamed to uniqueArgs, to correspond with the dashboard and the documentation.

@jameshfisher
Copy link
Author

(That said, "unique args" is a bizarre name, and should be called "tags" or "private metadata". But the most important thing is consistency - just call it one thing!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant