Add test case for PHP short-hand echo syntax #3246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PHP short-hand echo example to echoed-requests test cases
0xDC0DE
approved these changes
Jan 9, 2024
3 tasks
|
@appills I'm seeing a bunch of test failures in CI but I'm not sure I understand why they're happening. Could you please update your branch with the latest semgrep-rules:develop, maybe that's going to be enough to fix the failures :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
<?= ?>example for PHP to demonstrate that semgrep properly captures the short-hand echo as a sink