Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warn type to global context.logger #3423

Merged
merged 7 commits into from
Aug 17, 2024
Merged

Conversation

babblebey
Copy link
Member

@babblebey babblebey commented Aug 13, 2024

This Pull request adds the warn type to the semantic-release global context.logger instance.

Changes Made

  • Added new property warn to the Signale instantication config property types in get-logger.js script
export default ({ stdout, stderr }) =>
  new Signale({
    config: { displayTimestamp: true, underlineMessage: false, displayLabel: false },
    disabled: false,
    interactive: false,
    scope: "semantic-release",
    stream: [stdout],
    types: {
      error: { badge: figures.cross, color: "red", label: "", stream: [stderr] },
      log: { badge: figures.info, color: "magenta", label: "", stream: [stdout] },
      success: { badge: figures.tick, color: "green", label: "", stream: [stdout] },
      warn: { badge: figures.warning, color: "yellow", label: "", stream: [stderr] }, // 👈 👈 👈 👈  HERE
    },
  });

Related Issue

Fixes #3422

@babblebey babblebey marked this pull request as ready for review August 16, 2024 20:57
@babblebey babblebey requested a review from a team August 16, 2024 20:57
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@babblebey babblebey merged commit bcc663c into master Aug 17, 2024
10 checks passed
@babblebey babblebey deleted the feat/warning-logger branch August 17, 2024 12:24
Copy link

🎉 This PR is included in version 24.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no logger.warn right now, it would need to be added in semantic-release core
2 participants