Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow - in event query #242

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Allow - in event query #242

merged 1 commit into from
Aug 15, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Aug 15, 2024

Describe your changes and provide context

Some contracts define there event topic with - which is currently not queryable. This PR allows such keys to be queried.

Testing performed to validate your change

local sei

@codchen codchen closed this Aug 15, 2024
@codchen codchen reopened this Aug 15, 2024
@codchen codchen merged commit 96d05f0 into main Aug 15, 2024
22 checks passed
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.23%. Comparing base (784a8e0) to head (9a4184a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   58.14%   58.23%   +0.09%     
==========================================
  Files         249      249              
  Lines       34485    34485              
==========================================
+ Hits        20051    20084      +33     
+ Misses      12845    12813      -32     
+ Partials     1589     1588       -1     
Files Coverage Δ
internal/pubsub/query/syntax/scanner.go 81.18% <100.00%> (ø)

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant