Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config related stats for a default writer config #1202

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

sharpyfox
Copy link
Contributor

Looks like there is a mistake in getting some config parameters for stats in writer. Writer is using getters like writeBackoffMin() to get actual data, but stats are using direct config values with w.WriteBackoffMin which means that some stats are 0 by default

Copy link
Contributor

@petedannemann petedannemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sharpyfox !

@petedannemann petedannemann merged commit 260dd54 into segmentio:main Oct 6, 2023
12 checks passed
@sharpyfox sharpyfox deleted the fix-writer-stats branch October 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants