Add DeleteGroups function to Client #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsun
reviewed
Mar 24, 2023
Comment on lines
24
to
28
| ErrorCode: 1, | ||
| }, | ||
| { | ||
| GroupID: "group2", | ||
| ErrorCode: 1, |
There was a problem hiding this comment.
ErrorCode 1 is a failure, could you write a test case that succeeds as well
deletegroups.go
Outdated
Comment on lines
56
to
60
| if t.ErrorCode == 0 { | ||
| ret.Errors[t.GroupID] = nil | ||
| } else { | ||
| ret.Errors[t.GroupID] = Error(t.ErrorCode) | ||
| } |
There was a problem hiding this comment.
use the makeError function instead of Error (see other examples for usage)
also don't need the if/else statement as makeError takes care of that too
There was a problem hiding this comment.
thanks for the review, I've made the changes.
nlsun
approved these changes
Mar 27, 2023
|
Thanks @bgranvea ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DeleteGroups protocol and add it to Client.