-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returns empty citation with some formats when citation contains certain cyrillic characters #49
Comments
Hey Nate, I'm currently busy. I will lookup for a fix soon. |
No problem, I'm the same. Thanks for looking into it. 👍 |
I'm not able to encode the Array dump into JSON. Please call json_encode and pass that stdClass object and post the result here. Thank you! |
Sure, here it is in JSON. It looks like maybe the characters in the title have been transformed a bit, but it may also be that my test data has changed a bit (still get the same errors though): {
"type": "article-journal",
"id": "30",
"title": "Est maximus eu donec congue \\u201cNe\\u0161to Izme\\u0111u\\u201d Sr\\u0111ana Karanovi\\u0107\\u201ca",
"container-title": "Journal of Public Knowledge",
"container-title-short": "publicknowledge",
"volume": "2",
"issue": "3",
"section": "Articles",
"URL": "http:\\/\\/localhost\\/ojs\\/publicknowledge\\/article\\/view\\/30",
"accessed": {
"raw": "2018-04-11"
},
"author": [{
"family": "Corino",
"given": "Carlo"
}, {
"family": "Contributor",
"given": "Test"
}, {
"family": "Another",
"given": "Test"
}],
"issued": {
"raw": "2017-10-17 00:00:00"
},
"DOI": "10.1234\\/publicknowledge.v2i3.30"
} |
now checks if the first character of a word is a valid utf-8 letter that can be uppercased, before running ``mb_strtoupper``.
Okay, I've determine the problem. The stylesheet specifies that the title should be formatted using
To do this I split the title into single words by spaces and hyphen. The Please test if the issue is solved by using the branch issue-49. If everything fine, i will make a bugfix release soon. |
Fix confirmed. Thanks for another quick fix! I'll look forward to the next release. 👍 |
Okay! 2.1.2 has been released. |
Please follow the general troubleshooting steps first:
Bug reports:
We're getting an empty citation returned when passing a citation for a journal article titled
Est maximus eu donec congue “Nešto Između” Srđana Karanović“a
. It returns:Used CSL stylesheet:
Can reproduce this with chicago-author-date.csl and turabian-fullnote-bibliography.csl.
Used CSL metadata
We pull the citation data from PHP, so here's the
stdClass
that I pass toCiteProc::render
:The text was updated successfully, but these errors were encountered: