Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when data provider is invalid #5964

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 24, 2024

closes #5963

I did not provide a new test, because I think adjustments of expectations of existing tests already cover everything needed.

@staabm staabm marked this pull request as ready for review September 24, 2024 08:25
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (ba61e62) to head (6e09423).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5964   +/-   ##
=========================================
  Coverage     94.62%   94.62%           
  Complexity     6752     6752           
=========================================
  Files           713      713           
  Lines         20374    20375    +1     
=========================================
+ Hits          19278    19279    +1     
  Misses         1096     1096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann merged commit 9223252 into sebastianbergmann:main Sep 27, 2024
25 checks passed
@staabm staabm deleted the bug5963 branch September 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message when data provider is invalid
2 participants