Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): argument names #37

Merged
merged 3 commits into from
Jul 16, 2024
Merged

refactor(cli): argument names #37

merged 3 commits into from
Jul 16, 2024

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Jul 16, 2024

Proposed Changes

More intuitive cli options.

Types of Changes

What types of changes does your code introduce? Put an x in the boxes that
apply

  • A bug fix (non-breaking change which fixes an issue).
  • A new feature (non-breaking change which adds functionality).
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected).
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    guidelines.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation (if appropriate).

Copy link
Member

@supermaxiste supermaxiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I read into good practices for CLI naming for arguments and -x seems like the best solution for our case 👍

@cmdoret cmdoret merged commit 1a6decc into main Jul 16, 2024
7 checks passed
@cmdoret cmdoret deleted the fix/cli-args branch July 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants