Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Copyright #35

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Added Copyright #35

merged 1 commit into from
Jul 12, 2024

Conversation

ksanao
Copy link
Contributor

@ksanao ksanao commented Jul 12, 2024 •
edited
Loading

Proposed Changes

Types of Changes

What types of changes does your code introduce? Put an x in the boxes that
apply

  • A bug fix (non-breaking change which fixes an issue).
  • A new feature (non-breaking change which adds functionality).
  • A breaking change (fix or feature that would cause existing
    functionality to not work as expected).
  • A non-productive update (documentation, tooling, etc. if none of the
    other choices apply).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • I have read the
    CONTRIBUTING
    guidelines.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation (if appropriate).

Further Comments

@ksanao ksanao requested a review from cmdoret July 12, 2024 10:36
cmdoret
cmdoret approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, thanks!

@cmdoret cmdoret merged commit 0b2dba1 into main Jul 12, 2024
7 checks passed
@cmdoret cmdoret deleted the docs/add-copyright branch July 12, 2024 10:49
gabyx added a commit that referenced this pull request Jul 15, 2024
@gabyx
fix: add rayon dependency
51cd62f 
fix: correct all clippy errors

fix: add CLI argument to setup the thread pool

fix: CLI handling

fix: wrong argument

docs(readme): add copyright notice (#35)

fix: parallelize also second pass

fix: correct output in `write` -> `write_all`

- `write` may fail an return the number of bytes written, which is
  the wrong function.

fix: remove from first-pass since no benefit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmdoret cmdoret cmdoret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksanao @cmdoret