-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support terminology codes #106
Open
cmdoret
wants to merge
24
commits into
main
Choose a base branch
from
feat/fuzon-codes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdoret
commented
Oct 2, 2024
deploy/fuzon/Dockerfile
Outdated
|
||
RUN apt-get update && apt-get install -y git | ||
|
||
RUN git clone https://github.com/sdsc-ordes/fuzon.git --branch feat/fuzon-http . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: clone release instead of branch, once PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for terminology codes instead of free text for specific metadata fields, along with autocomplete suggestion in the terminal.
Currently, the following properties/terminologies are used:
Major changes
Trying it
To test local autocomplete in terminal:
To rely on the server for autocomplete:
Notes
Codes are recommended based similarity between user input and labels, but only the URIs are persisted in metadata.
Follow up (separate issues):
Open questions
When creating a modos from input yaml (instead of interactively) (see
data/ex_config.yaml
), URIs are now required for the 3 properties above.It may be painful for users to find out what URIs to input in the yaml. Should we provide some kind of subcommand just to get the codes (basically a fuzon wrapper)?
Perhaps something along the lines of this