Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax childprocess dependency version #649

Closed
wants to merge 2 commits into from

Conversation

delphaber
Copy link

childprocess turned 1 on January, so I tried to relax childprocess dependency version from ~> 0.6 to >= 0.6.3.

Let's see if CI passes :)

@delphaber
Copy link
Author

Dang! It breaks on Windows! Maybe because of enkessler/childprocess#132 ? 🤔

@sds
Copy link
Owner

sds commented Jun 26, 2019

Thanks for the PR, @delphaber.

Yes, childprocess requires the ffi gem to be installed on Windows machines. However, it doesn't require this by default since most use cases don't need it and it slows down installs. See enkessler/childprocess#150 for context.

I think the simplest workaround is to add the following to this project's Gemfile so we get the tests to pass on Windows:

gem 'ffi' if Gem.win_platform?

What do you think?

@delphaber
Copy link
Author

Makes totally sense! thanks :) I'm updating the PR

@delphaber
Copy link
Author

Done! Let's wait for the CIs :)

@sds
Copy link
Owner

sds commented Jun 29, 2019

Thanks for the PR! Fixed the broken test and merged in #653.

@sds sds closed this Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants