Allow rake 13 #313
Merged
Allow rake 13 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAICT, the only breaking change in rake 13 is dropping support for ruby < 2.2.
|
Checking the changelog, this is my interpretation as well. Seems safe and this gem is a blocker for me to upgrade the global rake version in my gemfile. |
sds
added a commit
that referenced
this pull request
Oct 2, 2019
This isn't needed by default—it's only needed if users want to use the Rake integration. Remove it so we can avoid issues like #313.
|
Thanks @jaredbeck. Given this is only needed for the Rake integration, I removed it entirely in 4373b51 and updated the documentation to mark it optional. I imagine most users don't utilize this integration. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT, the only breaking change in rake 13 is dropping support for ruby < 2.2.