Improve schema backup #4008
Merged
Improve schema backup #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michal-Leszczynski
force-pushed
the
ml/improve-schema-backup
branch
from
274e90e
to
c474f44
Compare
|
@karol-kokoszka This PR is ready for review! |
|
@karol-kokoszka I believe that this should also be included in 3.3.2 for safety reasons. |
karol-kokoszka
approved these changes
Sep 4, 2024
In case of a cluster with only some nodes supporting desc schema backup/restore, SM should assume that the schema will be restored to a cluster with desc schema restore support. This means that SM should back up desc schema with internals output from a node which supports it.
It is possible that even though SM has CQL credentials, it can directly connect to only some of the nodes via CQL. Fixes #4007
…chema Backups of clusters that restore from desc schema shouldn't be allowed when the CQL creds are not set. This might break some backup tasks, but it is better than silently skipping this step and founding out about it during restore. Fixes #3995
Previous commit made it impossible to perform backup of cluster that restores schema from desc schema without CQL creds. In order to make up for that, backup properties are extended with DontBackupSchema which can be deliberately set in order to skip schema backup and allow to back up user data when no CQL creds were set.
Michal-Leszczynski
force-pushed
the
ml/improve-schema-backup
branch
from
c474f44
to
83584cc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a several changes regarding schema backup.
They aim to increase schema backup safety by making it impossible to skip schema backup by simply not providing CQL creds (which was possible for Scylla version >= 6.0). Skipping schema backup is still possible (some users might not want to provide the CQL creds), but requires user to deliberately add the new
--skip-schemaflag.They also make the schema backup more robust for multi Scylla version cluster, or a cluster where SM does not have CQL access to all of the nodes.
Fixes #4007
Fixes #3995