Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python driver): use 'ssl_context' instead 'ssl_options' #7142

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix(python driver): use 'ssl_context' instead 'ssl_options' #7142

merged 1 commit into from
Jan 25, 2024

Conversation

juliayakovlev
Copy link
Contributor

@juliayakovlev juliayakovlev commented Jan 24, 2024 •
edited
Loading

SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

@juliayakovlev juliayakovlev force-pushed the use_ssl_context_for_python_driver branch 2 times, most recently from 5bcc4ab to 2e7a639 Compare January 25, 2024 10:27
@juliayakovlev
fix(python driver): use 'ssl_context' instead 'ssl_options'
957af23 
SCT python driver is using ssl_options when create session and should be switching to use
ssl_context since ssl_options is deprecated (and also broken for scylla-driver==3.26.4 ontop
python 3.12)

Refs: scylladb/python-driver#284
@juliayakovlev juliayakovlev force-pushed the use_ssl_context_for_python_driver branch from 2e7a639 to 957af23 Compare January 25, 2024 11:44
fruch
fruch reviewed Jan 25, 2024
View reviewed changes
sdcm/cluster.py Show resolved Hide resolved
@fruch fruch added the test-integration Enable running the integration tests suite label Jan 25, 2024
fruch
fruch approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliayakovlev juliayakovlev changed the title use_ssl_context_for_python_driver fix(python driver): use 'ssl_context' instead 'ssl_options' Jan 25, 2024
@juliayakovlev juliayakovlev marked this pull request as ready for review January 25, 2024 13:23
@juliayakovlev juliayakovlev added backport/2023.1 Need to backport to 2023.1 backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 labels Jan 25, 2024
@juliayakovlev juliayakovlev mentioned this pull request Jan 25, 2024
Open
@fruch fruch merged commit 62df88f into scylladb:master Jan 25, 2024
6 checks passed
@fruch fruch added backport/2024.1-done Commit backported to 2024.1 backport/5.4-done Commit backported to 5.4 backport/2023.1-done Commit backported to 2023.1 labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch fruch approved these changes

@soyacz soyacz Awaiting requested review from soyacz

Assignees

@juliayakovlev juliayakovlev

Labels
backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/2023.1-done Commit backported to 2023.1 backport/2023.1 Need to backport to 2023.1 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1 test-integration Enable running the integration tests suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliayakovlev @fruch