Make blocking set keyspace query to fail by timeout #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/add-schema-refresh-timeout
branch
from
eaacfb9
to
1e050fe
Compare
|
I'll repeat what I said on previous PR: I think the root cause is that the disconnected connection is not detected and that is what we should fix. If we correctly detect connection disconnect, then it will error out all the requests on this connection, which will fix infinite waiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is reimplementing stale PR
set_keyspace_blockingis called from places holding a lock, and in case that the connection is closed from the server side, it might hang forever.using the
connect_timeouton it to make sure itwon't hang forever.
Closes: #261