Connection to a ScyllaDB cluster is delayed as the driver tries to qu…

[mykaul]

…ery system.peers_v2 table

Fixes: #245

Signed-off-by: Yaniv Kaul yaniv.kaul@scylladb.com

[Lorak-mmk]

I think we can merge this, as far as I can see by looking at the code this shouldn't break anything (but in the future I'd like to setup Cassandra CI to be sure).
Could you add a TODO comment to switch it back when (if?) Scylla adds peers_v2 table?

[mykaul]

I think we can merge this, as far as I can see by looking at the code this shouldn't break anything (but in the future I'd like to setup Cassandra CI to be sure).
Could you add a TODO comment to switch it back when (if?) Scylla adds peers_v2 table?

Do we have such plans? I see it was added to Cassandra as part of https://issues.apache.org/jira/browse/CASSANDRA-7544 - what are we missing that we'd like to add to ScyllaDB?

[Lorak-mmk]

I have no idea if we need it or have any plans to implement it.
But now I look at the code that added peers_v2 support in this driver: datastax@40fe726
and it looks like it is a feature used by C*.
I'd like to avoid breaking C* compatibility, so what do you think about only disabling PEERS_V2 when connecting to Scylla?
The patch would probably look like this (I didn't test it, it's just the idea): Lorak-mmk@ed97974

[fruch]

I have no idea if we need it or have any plans to implement it. But now I look at the code that added peers_v2 support in this driver: datastax@40fe726 and it looks like it is a feature used by C*. I'd like to avoid breaking C* compatibility, so what do you think about only disabling PEERS_V2 when connecting to Scylla? The patch would probably look like this (I didn't test it, it's just the idea): Lorak-mmk@ed97974

I agree it's a better direction, assuming it works.

[mykaul]

I have no idea if we need it or have any plans to implement it. But now I look at the code that added peers_v2 support in this driver: datastax@40fe726 and it looks like it is a feature used by C*. I'd like to avoid breaking C* compatibility, so what do you think about only disabling PEERS_V2 when connecting to Scylla? The patch would probably look like this (I didn't test it, it's just the idea): Lorak-mmk@ed97974

Done.