Move schema agreement to asyncio #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
force-pushed
the
fix-168-v2
branch
4 times, most recently
from
53097b1
to
c2c2862
Compare
Fixes scylladb#168. See the issue description for more detailed description of the bug. This commit introduces asyncio Event Loop to Cluster object. This loop is now responsible for executing most of wait_for_schema_agreement code, the only part delegated to executor is the one that actually sends request to a node. This way tasks executing on executor doesn't have to wait on any locks, preventing deadlocks. In the future we can move more code to Cluster.loop and eventually retire Cluster.scheduler.
|
Looks interesting, wondering if it would play nicely when more loops are used, like in scylla unittests or when asyncio is used as backend (no sure it's working at all) |
|
I don't think more loops should be a problem. We'll see for sure when I get this to work. |
|
@Lorak-mmk now that we are running more of dtest as gating, we started seeing this issue also in dtest anything I can do to help with this one ? |
|
scylladb/scylladb#16676 might be relevant. |
|
This PR was obsoleted by #256 , so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168. See the issue description for more detailed description of the bug.
This commit introduces asyncio Event Loop to Cluster object. This loop is now responsible for executing most of wait_for_schema_agreement code, the only part delegated to executor is the one that actually sends request to a node. This way parts delegated to executor don't have to wait on any locks, preventing deadlocks.
In the future we can move more code to
Cluster.loopand eventually retireCluster.scheduler.Fixes #168
Fixes #225