You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schemagen generates structs as [16]byte for uuid and timeuuid columns.
when a time/uuid column has nil value, the switch case will not match with *[]byte and returns the following error:
can not unmarshal X timeuuid into *[16]uint8
to solve this we can change Schemagen, or add the case here. personally I belive changing Schemagen has more cost and mapping UUIDs to [16]byte is better than mapping to []byte.
Schemagen generates structs as [16]byte for uuid and timeuuid columns.
when a time/uuid column has nil value, the switch case will not match with *[]byte and returns the following error:
`can not unmarshal X timeuuid into *[16]uint8`
to solve this we can change Schemagen, or add the case here. personally I belive changing Schemagen has more cost and mapping UUIDs to [16]byte is better than mapping to []byte.
izenhaim
changed the title
Bug fix: Add matching case for nil uuid column
Bug fix: Add matching case for unmarshalling nil uuid column
Aug 20, 2024
@sylwiaszunejko@dkropachev
I'm sorry for mentioning you, since this is causing a lot of problems for us, I wanted to get your opinion on it sooner.
Thanks.
@sylwiaszunejko@dkropachev I'm sorry for mentioning you, since this is causing a lot of problems for us, I wanted to get your opinion on it sooner. Thanks.
@izenhaim , thanks for you contribution, my bad we have not picked it up yearlier.
Glad to be of help! will you release a version as well?
Releasing it take a one week, meanwhile you can use fixed version as the following: replace github.com/gocql/gocql => github.com/scylladb/gocql v1.14.3-0.20240820095829-00277be38708
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
izenhaim
changed the title
Schemagen generates structs as [16]byte for uuid and timeuuid columns.
when a time/uuid column has nil value, the switch case will not match with *[]byte and returns the following error:
can not unmarshal X timeuuid into *[16]uint8to solve this we can change Schemagen, or add the case here. personally I belive changing Schemagen has more cost and mapping UUIDs to [16]byte is better than mapping to []byte.