Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregate bug #152

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix aggregate bug #152

merged 2 commits into from
Nov 2, 2023

Conversation

sylwiaszunejko
Copy link
Collaborator

Previously strings used to parse CREATE FUNCTION and CREATE AGGREGATE had errors, now it is fixed.

I also added testcase in recreate_test.go for testing aggregateToCQL.

Fixes: #130

@sylwiaszunejko sylwiaszunejko changed the title Aggregate bug Fix aggregate bug Nov 2, 2023
@avelanarius avelanarius mentioned this pull request Nov 2, 2023
Closed
@avelanarius avelanarius merged commit c700c52 into scylladb:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelanarius avelanarius avelanarius approved these changes

@Michal-Leszczynski Michal-Leszczynski Michal-Leszczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in aggregateToCQL
3 participants
@sylwiaszunejko @avelanarius @Michal-Leszczynski