Run go vet and tests in all subpackages in CI #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
force-pushed
the
mz/fix-ci-tests-vet
branch
2 times, most recently
from
106363c
to
2de9047
Compare
tnozicka
reviewed
Nov 11, 2022
scylla_test.go
Outdated
| @@ -167,6 +169,9 @@ func TestScyllaRandomConnPIcker(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("async access of max iterations", func(t *testing.T) { | |||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second) | |||
There was a problem hiding this comment.
On a busy system timeout as low as this could flake. Is there a particular issue you've encountered that forced you to start addressing this? Would collecting the errors be enough to fix the vet?
There was a problem hiding this comment.
Not just the vet, I noticed an issue and I fixed it, it's better to flake than hang infinitely. I increased the timeout to 5s which should be big enough even for busy system.
|
nit: the first commit name misses |
`go vet` and `go test` without any package arguments runs only on the go files in the repo root directory. It should run on all non-vendored packages.
Fixes following go vet failure: * ./scylla_test.go:180:4: call to (*T).Fatal from a non-test goroutine
zimnx
force-pushed
the
mz/fix-ci-tests-vet
branch
from
2de9047
to
1b91237
Compare
good catch, thanks. Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go vetandgo testwithout any package arguments runs onlyon the go files in the repo root directory. It should run on all
non-vendored packages.
Fixes following go vet failure:
./scylla_test.go:180:4: call to (*T).Fatal from a non-test goroutine