Release v1.1.2 #53
Merged
Release v1.1.2 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tox to the dependabot exclusions for the same reason as the other ignored dev dependencies: they are already pinned fairly liberally so we don't need to keep up with every minor version.
Previously, when the checker instance is created it requested the filename from flake8 in order to load the source and parse to obtain a typed AST, as the flake8 provided AST is not guaranteed to contain type information. While sufficient for parsing files, this falls apart when attempting to parse code piped to stdin & causes our plugin to error out. To mitigate these issues, the source is requested from flake8 as lines (list of strings), which is joined & passed into the typed AST generation rather than farming to a file IO task. This also allows us to drop the request for the AST from flake8 that we don't use, as requesting the lines will ensure that the plugin is registered. The related test helpers have been updated to accommodate the change in instantiation. Closes #52
We don't use format strings anywhere
SebastiaanZ
approved these changes
Dec 17, 2019
MarkKoz
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[v1.1.2]
Changed
flake8as lines of code rather than parsing it from the requested filename ourselves, allowing for proper parsing ofstdininputsflake8-string-formatfrom dev dependencies, asstr.format()isn't used anywhereFixed
stdinsource code instead of a filenameThis also adds some tox/CI related changes & cleanup.
Closes #52
Closes #48