[run-postgresql] Make the DB initialization atomic #310
Conversation
(complete all of its parts or retry it if some failed) Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
That variable is always false at that point. |
|
Closing, this will need to be redone yet based on the discussion in the original issue. |
|
Yet, re: That variable is always false at that point. - that was actually the intention. Always try to retry the DB init if the variable isn't set to something else than "false" yet. AFAICT this should be safe (if the DB entry already exists, calling next DB init won't touch it). But the problem is, if not the whole DB initialization process finished before, the missing phases won't be retried in the 2nd run :(. |
But re-initdb would fail, and that would fail the whole script/container run. |
|
Right, good catch, you are right. |
(complete all of its parts or retry it if some failed)
Might possibly fix: #309 (Didn't test it though)
Signed-off-by: Jan Lieskovsky jlieskov@redhat.com