gh-action: Adapt unittests to renamed CMake flags, fix using external gtest. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that the unit tests are adapted and actually test using external |
olifre
changed the title
|
The second commit I pushed just now fixes support for usage of external |
ellert
reviewed
Jun 23, 2022
| add_dependencies(scitokens-gtest gtest) | ||
| if( NOT SCITOKENS_EXTERNAL_GTEST ) | ||
| add_dependencies(scitokens-gtest gtest) | ||
| endif() | ||
| include_directories("${PROJECT_SOURCE_DIR}/vendor/gtest/googletest/include") |
There was a problem hiding this comment.
Also this line (include_directories ...) should be inside the if ( NOT SCITOKENS_EXTERNAL_GTEST ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the unit tests (in GitHub actions) to use the now prefixed CMake flags, changed as part of #84 .
Thanks for the very welcome change 👍 .